Tickets/dm 47381: Support Summit Observing Weeks 45-46 of 2024 #161
Conversation
…d before requesting OCPS processing.
| @@ -282,6 +295,9 @@ async def configure(self, config: types.SimpleNamespace): | |||
| if comp in self.camera.components_attr: | |||
| self.log.debug(f"Ignoring Camera component {comp}.") | |||
| setattr(self.camera.check, comp, False) | |||
| elif comp in ["mtdome", "mtdometrajectory"]: | |||
There was a problem hiding this comment.
why make it only mtdome and mtdometrajectory? shouldn't this be
elif comp in self.tcs.components_attr:
?
| if self.config.point_directly: | ||
| if np.abs(az_sun - (self.config.target_az % 360)) < min_sun_distance: | ||
| raise RuntimeError( | ||
| f"Distance from sun {az_sun - (self.config.target_az % 360)} is \ |
There was a problem hiding this comment.
Please, split the string like we normally do:
f"Distance from sun {az_sun - (self.config.target_az % 360)} is "
f"less than {min_sun_distance}. Stopping."
""
| else: | ||
| if np.abs(self.config.distance_from_sun) < min_sun_distance: | ||
| raise RuntimeError( | ||
| f"Distance from sun {self.config.distance_from_sun} is less than {min_sun_distance}. \ |
There was a problem hiding this comment.
Same as above, split the string like we normally do:
f"Distance from sun {self.config.distance_from_sun} is less than {min_sun_distance}. "
"Stopping."
| continue | ||
| else: | ||
| self.log.warning( | ||
| f"Calculated exposure time {exp_time} below min exposure time \ |
There was a problem hiding this comment.
Please, split the string like we normally do.
There was a problem hiding this comment.
This should not be included as part of this PR.
There was a problem hiding this comment.
Please do not include new scripts as part of the run branch. The author needs to open a separate PR to include this.
| @@ -118,6 +119,14 @@ async def take_images( | |||
| reason="EXTRA" + ("" if self.reason is None else f"_{self.reason}"), | |||
| program=self.config.program, | |||
| ) | |||
| self.log.info("Waiting for data to be ingested by OODS.") | |||
| for _ in range(9): | |||
There was a problem hiding this comment.
I think I did this one but we should not have a hard-coded number here. Can you make this a class attribute?
There was a problem hiding this comment.
This should not be part of this PR.
There was a problem hiding this comment.
This should not be part of this PR.
No description provided.