Merge pull request #305 from lsst-ts/tickets/DM-48416

DM-48416: Declare isr in pipeline before referencing it

.gitignore

@@ -12,6 +12,7 @@ config.log
 # Built by sconsUtils
 version.py
 /bin/
+python/*.dist-info/
 
 # Pytest
 tests/.tests

doc/versionHistory.rst

@@ -6,6 +6,14 @@
 Version History
 ##################
 
+.. _lsst.ts.wep-13.3.1:
+
+-------------
+13.3.1
+-------------
+
+* Add isr configs back into default pipelines.
+
 .. _lsst.ts.wep-13.3.0:
 
 -------------

pipelines/_ingredients/wepDirectDetectScienceGroupPipeline.yaml

@@ -1,6 +1,19 @@
 description: wep direct detect pipeline
 
 tasks:
+  isr:
+    class: lsst.ip.isr.IsrTaskLSST
+    config:
+      # Although we don't have to apply the amp offset corrections, we do want
+      # to compute them for analyzeAmpOffsetMetadata to report on as metrics.
+      doAmpOffset: true
+      ampOffset.doApplyAmpOffset: false
+      # Turn off slow steps in ISR
+      doBrighterFatter: false
+      # Mask saturated pixels,
+      # but turn off quadratic crosstalk because it's currently broken
+      doSaturation: True
+      crosstalk.doQuadraticCrosstalkCorrection: False
   generateDonutDirectDetectTask:
     class: lsst.ts.wep.task.generateDonutDirectDetectTask.GenerateDonutDirectDetectTask
     config:

pipelines/production/comCamSimRapidAnalysisPipeline.yaml

@@ -3,6 +3,9 @@ instrument: lsst.obs.lsst.LsstComCamSim
 imports:
   - $TS_WEP_DIR/pipelines/_ingredients/wepDirectDetectScienceGroupPipeline.yaml
   - $TS_WEP_DIR/pipelines/_ingredients/donutVizGroupPipeline.yaml
+tasks:
+  aggregateDonutTablesTask:
+      class: lsst.donut.viz.AggregateDonutTablesTask
 
 # Define pipeline steps
 subsets:

tests/test_pipelines.py

@@ -0,0 +1,45 @@
+# This file is part of ts_wep.
+#
+# Developed for the LSST Telescope and Site Systems.
+# This product includes software developed by the LSST Project
+# (https://www.lsst.org).
+# See the COPYRIGHT file at the top-level directory of this distribution
+# for details of code ownership.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+import unittest
+from glob import glob
+from pathlib import Path
+
+from lsst.pipe.base import Pipeline
+from lsst.utils import getPackageDir
+
+
+class TestPipeline(unittest.TestCase):
+    """Test the pipeline."""
+
+    def testPipeline(self):
+        packageDir = getPackageDir("ts_wep")
+        # only test production pipelines
+        pipelinePattern = Path(packageDir) / "pipelines" / "production"
+        files = glob(pipelinePattern.as_posix() + "/*.yaml")
+        for filename in files:
+            pipeline = Pipeline.fromFile(filename)
+            self.assertIsInstance(pipeline, Pipeline)
+
+
+if __name__ == "__main__":
+    # Do the unit test
+    unittest.main()