Fix crash with the index type function, where it would stack overflow due to not waiting for a pending-expansion #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A Unit Test is going to appear soon! I need to cope with the 🙏 |
|
Unit Test is there now |
aatxe
requested changes
Sep 13, 2024
Analysis/src/TypeFunction.cpp
Outdated
Comment on lines
2210
to
2216
| // Whether the type is still pending. | ||
| // | ||
| // TODO: A generalized sanity check function for all type functions? | ||
| // But it should be optional for customization | ||
| // for functions that specifically need type function | ||
| // This here fixes a stack overflow. | ||
| // https://github.com/luau-lang/luau/issues/1406 |
There was a problem hiding this comment.
Can you please remove all of this comment? isPending is the "generalized sanity check" that should be called for each type parameter to a type function.
There was a problem hiding this comment.
Alright, give me a second
aatxe
reviewed
Sep 13, 2024
aatxe
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1406
While it is good to let
indexwait for the pending-expansion. To re-produce the issue you need more than just this code: https://i.imgur.com/b3OmUGF.pngIt needs this, else it won't crash.
But regarding "pending things", I'd recommend generalized functions for sanity checks like these, since there will be more cases of similar issues I believe. But I am 100% sure that eventually this issue here can maybe be prevented if looking at the Constraints. (And optimization) Not sure if
indexneeds the table fully completed, or if it is preferred that the info is available based on how much info is available at the current position in the code.But if this gets done, I hope that they'll be connected to the Solver Logger, because I actually refined mine with colors and more info (yet need to finish that) to understand the Luau Source Code more and to debug issues.