Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Pull request #960 generate a compiling error with activated CAMERA_DEVICE = CAMERA_MODEL_AI_THINKER #963

Closed
DivingDuck opened this issue Nov 9, 2023 · 3 comments

Comments

@DivingDuck
Copy link

DivingDuck commented Nov 9, 2023

Describe the bug

Last code update from pull request #960 generates a compiler error when a camera modul is activated (in my case CAMERA_DEVICE = CAMERA_MODEL_AI_THINKER)

Error:

Involved files:
configuration.h, line 493
camera.cpp, line 81

**'HTTP_Server' has not been declared
name followed by '::' must be a class or namespace name**

To Reproduce

Activate CAMERA_DEVICE = CAMERA_MODEL_AI_THINKER in configuration.h, line 493

Expected behavior

n/a, compiling w/o error

Screenshots

ESP3D_issue#963

ESP3D Firmware:

  • ESP3D FW version: 3.0.0.a225

  • ESP3D-WebUI Version: 3.0.0-a42S2

  • Wifi mode: STA

  • Flash method: OTA
    Build with VSC and PlatformIO:

  • Any change done in FW:
    see configuration.h in attachment

Target Firmware:

  • Name: Smoothieware

Board used (please complete the following information):

  • MCU: ESP32
  • Name: ESP32CAM
  • Flash size: 4M

Additional context

Up to last update ESP3D was compiling fine.
Turning camera.cpp, line 81 into a comment line will compile the firmware.
After uploading the new firmware I recognize in -->Settings --> Features a error message parsing data error, data are incorrect

Attachment:

ESP3D-Issue#963.zip

Edit: forgot attachment...

@DivingDuck DivingDuck added the bug label Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

Thank your for submiting, please be sure you followed template or your issue may be dismissed. if you deleted the template it is here

@luc-github luc-github changed the title Pull request #960 generate a compiling error with activated CAMERA_DEVICE = CAMERA_MODEL_AI_THINKER [BUG]Pull request #960 generate a compiling error with activated CAMERA_DEVICE = CAMERA_MODEL_AI_THINKER Nov 9, 2023
luc-github added a commit that referenced this issue Nov 9, 2023
Add missing header file for adding ESP3D User Agent in request
@luc-github
Copy link
Owner

Indeed this case did not go thrue the CI test and I forget to add the corresponding header, thank you for raising the issue - it is now fixed 265e0e6

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants