adding sentinel timeout parameters #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that pkgconfig is in side lib directory
| */ | ||
| inline static ptr_t createTimeout(const std::string& host="localhost", | ||
| const unsigned int port=6379, | ||
| const struct timeval timeout=defaultTimeout()) |
There was a problem hiding this comment.
For consistency with the rest of the project, I'd like create_timeout instead of createTimeout. So underscore syntax. Is it a problem for you?
Also, why not using std::chrono time intervals instead of struct timeval? Could it be more C++11 friendly?
There was a problem hiding this comment.
Yes, I can change to create_timeout.
I used struct timeval because that what is used by hiredis redisConnectWithTimeout
struct timeval timeout = { 1, 500000 }; // 1.5 seconds c = redisConnectWithTimeout(hostname, port, timeout);
|
Thanks for your contribution! Looks good, I did some comments inline with the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows for lower connectivity timeout when connecting to sentinels in redis HA cluster mode.