fixes error accumulation both on Result and Validation Monads

lucapiccinelli · Mar 1, 2021 · 73830a4 · 73830a4
1 parent b51af88
commit 73830a4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -33,15 +33,15 @@ add in pom.xml
 <dependency>
     <groupId>io.github.lucapiccinelli</groupId>
     <artifactId>konad</artifactId>
-    <version>1.0.10</version>
+    <version>1.0.11</version>
 </dependency>
 ```
 
 #### Gradle
 add in build.gradle
 ```groovy
 dependencies {
-    implementation "io.github.lucapiccinelli:konad:1.0.10"
+    implementation "io.github.lucapiccinelli:konad:1.0.11"
 }
 ```
 

diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
 
     <groupId>io.github.lucapiccinelli</groupId>
     <artifactId>konad</artifactId>
-    <version>1.0.10</version>
+    <version>1.0.11</version>
     <packaging>jar</packaging>
 
     <name>io.github.lucapiccinelli konad</name>

diff --git a/src/main/kotlin/io/konad/Result.kt b/src/main/kotlin/io/konad/Result.kt
@@ -41,7 +41,7 @@ sealed class Result<out T>: ApplicativeFunctorKind<ResultOf, T>, MonadKind<Resul
         is Ok -> map(liftedFn.value)
         is Errors -> when(this){
             is Ok -> liftedFn
-            is Errors -> Errors(error, liftedFn)
+            is Errors -> Errors(error, prev?.let { Errors(it.error, liftedFn)} ?: liftedFn)
         }
     }
 

diff --git a/src/main/kotlin/io/konad/Validation.kt b/src/main/kotlin/io/konad/Validation.kt
@@ -65,7 +65,7 @@ fun <A, B, C> Validation<A, B>.ap(liftedFn: Validation<A, (B) -> C>): Validation
     is Validation.Success -> map(liftedFn.success)
     is Validation.Fail -> when(this){
         is Validation.Success -> liftedFn
-        is Validation.Fail -> Validation.Fail(fail, liftedFn)
+        is Validation.Fail -> Validation.Fail(fail, prev?.let { Validation.Fail(it.fail, liftedFn)} ?: liftedFn)
     }
 }