Add support for defining the content_scripts on the extension manifest #46
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexITC
force-pushed
the
add-content-script
branch
from
fb6760f to
8495082
Compare
|
The travis failure seems non-related to the changes. |
AlexITC
force-pushed
the
add-content-script
branch
from
8495082 to
1b6d0d9
Compare
|
@lucidd ping. |
1 similar comment
|
@lucidd ping. |
|
Ping from a second source. My team would welcome this HIGHLY. Thanks :) |
|
Ping from a third source.. looking forward to this! |
|
@domdorn I have forked the project which has this change and scalajs 1.0.0 integration: https://github.com/AlexITC/scala-js-chrome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.chrome.com/extensions/content_scripts