Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Service Worker #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds a Service Worker #6

wants to merge 2 commits into from

Conversation

franciscojgtz
Copy link

This takes care of issue #4. All assets get cached and the game can be played while offline. Any recommendations to improve the code provided, are welcome.

@dchubad
Copy link

dchubad commented Feb 16, 2022

This takes care of issue #4. All assets get cached and the game can be played while offline. Any recommendations to improve the code provided, are welcome.

This is one of my favourite old classics, you have done well with the main game itself however I am not too keen on the way it changes my css layouts when trying to fit this game into a page on my site. On my site I would like to add a page with my own header and footer with this game in the middle but without the game destroying my layout. because you have bound the css to the body it makes it hard to display it with my own site layout. Not too keen on the big chunky putchu links everywhere, those could be a lot better formatted to look smaller and nicer but you don't really need them everywhere. If I had the time I'd really clean this game up for you but time is something I have little of. Basically it would be great if these games were made to fit on our websites in a more friendly way. thanks for your efforts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants