Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables #249

Merged
merged 7 commits into from
Jul 13, 2023
Merged

Variables #249

merged 7 commits into from
Jul 13, 2023

Conversation

lukasoppermann
Copy link
Owner

@lukasoppermann lukasoppermann commented Jul 10, 2023 •
edited
Loading

This PR solves #248

Basic integration of Variables:

  • all get expoerted into the same file

  • names are generated: collection/mode/variable name

  • aliases are exported not resolved but as a valid w3c alias

  • linked variables / references

@coveralls
Copy link

coveralls commented Jul 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5516703576

  • 16 of 53 (30.19%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.6%) to 77.901%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/transformer/standardTransformer.ts 3 8 37.5%
src/utilities/prepareExport.ts 0 6 0.0%
src/utilities/getVariables.ts 8 34 23.53%
Files with Coverage Reduction New Missed Lines %
src/utilities/prepareExport.ts 2 0%
Totals Coverage Status
Change from base Build 5479777545: -3.6%
Covered Lines: 551
Relevant Lines: 699
💛 - Coveralls

@lukasoppermann lukasoppermann marked this pull request as ready for review July 11, 2023 06:45
@lukasoppermann lukasoppermann merged commit 27cb44f into main Jul 13, 2023
@lukasoppermann lukasoppermann deleted the variables branch July 13, 2023 17:56
@marcuzgabriel marcuzgabriel mentioned this pull request Jul 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasoppermann @coveralls