Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "(Gitlab Project) Token" to commit file directly to GitLab #307

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

tatashidayat
Copy link
Contributor

@tatashidayat tatashidayat commented Jun 5, 2024

Hi @lukasoppermann,

Please help review this PR. I'm trying to implement #306

Screenshots
image
image

Thanks

package.json Outdated Show resolved Hide resolved
Copy link
Owner

@lukasoppermann lukasoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the great PR, I added a few questions / comments.

@tatashidayat
Copy link
Contributor Author

I've update the PR and replies some comments, please help to check it again.

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9459684931

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 59 (0.0%) changed or added relevant lines in 3 files are covered.
  • 27 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-6.9%) to 59.536%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utilities/base64.ts 0 6 0.0%
src/ui/modules/urlExport.ts 0 13 0.0%
src/ui/modules/gitlabRepository.ts 0 40 0.0%
Files with Coverage Reduction New Missed Lines %
src/config/commands.ts 1 0.0%
src/ui/modules/urlExport.ts 26 0.0%
Totals Coverage Status
Change from base Build 8422990754: -6.9%
Covered Lines: 467
Relevant Lines: 783

💛 - Coveralls

@lukasoppermann lukasoppermann merged commit 954e74a into lukasoppermann:main Jun 28, 2024
1 check passed
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9712675561

Details

  • 0 of 59 (0.0%) changed or added relevant lines in 3 files are covered.
  • 27 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-7.4%) to 69.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utilities/base64.ts 0 6 0.0%
src/ui/modules/urlExport.ts 0 13 0.0%
src/ui/modules/gitlabRepository.ts 0 40 0.0%
Files with Coverage Reduction New Missed Lines %
src/config/commands.ts 1 0.0%
src/ui/modules/urlExport.ts 26 0.0%
Totals Coverage Status
Change from base Build 9682764091: -7.4%
Covered Lines: 548
Relevant Lines: 791

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants