Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some texts don't have translations #1152

Open
rinodrummer opened this issue Jul 21, 2023 · 3 comments
Open

Some texts don't have translations #1152

rinodrummer opened this issue Jul 21, 2023 · 3 comments
Labels
0.x bug Something isn't working
Milestone

Comments

@rinodrummer
Copy link

  • Lunar version: 0.4
  • Laravel Version: 10.15.0
  • PHP Version: 8.1

While testing for Italian translation me and @sebhd1 noticed that most of the texts in packages/admin/resources/views/partials/forms/discount.blade.php are not using __() so there are no related entries in translation files.

@rinodrummer rinodrummer added the bug Something isn't working label Jul 21, 2023
@rinodrummer rinodrummer changed the title Discount form doesn't have translations Some texts doesn't have translations Jul 21, 2023
@sebhd1
Copy link

sebhd1 commented Jul 21, 2023

While going on testing, we also discovered that the translations are missing on the specified file: lunar/packages/admin/src/Menu/SettingsMenu.php.

@rinodrummer rinodrummer changed the title Some texts doesn't have translations Some texts don't have translations Jul 21, 2023
@glennjacobs
Copy link
Contributor

You may as well update them when doing your translation PR.

@rinodrummer
Copy link
Author

rinodrummer commented Jul 21, 2023

You may as well update them when doing your translation PR.

Ok! Perfect!

We were worried about the conventions relative to the keys in the translation files, but we'll try our best to match the standards!

We will keep writing here where we spot issues just to keep track and then close the issue along with the PR we are going to open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.x bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants