Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Pricing management #1515

Merged
merged 20 commits into from
Feb 14, 2024
Merged

Feature - Pricing management #1515

merged 20 commits into from
Feb 14, 2024

Conversation

alecritson
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 10:38pm

@alecritson alecritson added this to the v1.0 milestone Jan 30, 2024
@alecritson alecritson linked an issue Jan 30, 2024 that may be closed by this pull request
@glennjacobs
Copy link
Contributor

Doesn't initially set the default currency

image

@glennjacobs
Copy link
Contributor

I think we default this to "1"

image

@glennjacobs
Copy link
Contributor

I think "Comparison Price" sounds better. Also, I think it could do with some helper text as a lot of developers don't know what to use it for.

image

@glennjacobs
Copy link
Contributor

I think we might need to look at a money field component, as not showing the decimal places looks a bit naff.

image

@glennjacobs
Copy link
Contributor

It's a bit odd these both have the "Pricing" title. Perhaps change the bottom one to "Prices"?

image

Copy link
Contributor

@glennjacobs glennjacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@alecritson alecritson force-pushed the feature/pricing-management branch from 2cc1587 to 41a0167 Compare February 1, 2024 10:25
@glennjacobs
Copy link
Contributor

We don't have the comparison price fields for the "Base Prices", which we'll need.

I'm unsure of the term "Base Price" as this generally means the price before any additional charges. But currently not sure of a better term. I'll do some research.

Can the hint use this text "Automatically generated based on currency exchange rates.", please?

For the Price Breaks table could we add the following description? "Reduce the price when a customer purchases in larger quantities."

@alecritson alecritson marked this pull request as ready for review February 2, 2024 08:21
@glennjacobs glennjacobs merged commit 40cbf1b into 1.x Feb 14, 2024
17 checks passed
@glennjacobs glennjacobs deleted the feature/pricing-management branch February 14, 2024 22:41
webpatser added a commit to webpatser/lunar that referenced this pull request Feb 15, 2024
* 1.x:
  Feature - Discount editing (lunarphp#1542)
  Update ManageProductShipping.php
  Feature - Prevent delete action on resources with childs (lunarphp#1532)
  Feature - Brand urls and tweaks (lunarphp#1541)
  Chore - Update larastan/larastan (lunarphp#1558)
  chore: fix code style
  Feature - Field translated text (lunarphp#1505)
  Fix tests
  Revert "Quantity break fixes"
  Quantity break fixes
  Feature - Pricing management (lunarphp#1515)
  Improved dashboard KPIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Product price editing improvements
2 participants