bugfix: bitbucket paged results, use next page id versus incrementing… #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… integer to support bitbucket paged alphanumeric ids
twilly86
commented
Mar 1, 2022
| if (!isLastPage) | ||
| { | ||
| var myUri = new Uri(selectorResults.Next); | ||
| var nextPage = myUri.DecodeQueryParameters().FirstOrDefault(x => x.Key == "page"); |
There was a problem hiding this comment.
parse out the page id from the "next" url and use that for the next pge versus auto incrementing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making the request..
https://developer.atlassian.com/cloud/bitbucket/rest/api-group-pullrequests/#api-repositories-workspace-repo-slug-pullrequests-pull-request-id-comments-get
the next page id was alphanumeric id, grabbed from the "next" page url.
Update api client to parse out the "next" page parameter and use that versus incrementing the page id.
… integer to support bitbucket paged alphanumeric ids