Skip to content

Commit

Permalink
tcp_in : fix ooseq update error
Browse files Browse the repository at this point in the history
if a pbuf received with the same seqno in ooseq ,
we then check  the size and replace the existing one
with the larger one,but if the existing one is the
last segment in ooseq ,it might has been trimed before.
the replacing action will overrun our receive windows

see patch #10106 and bug #56397
  • Loading branch information
duckpowermb authored and goldsimon committed Oct 12, 2023
1 parent de0b978 commit 574bd6e
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/core/tcp_in.c
Original file line number Diff line number Diff line change
Expand Up @@ -1687,6 +1687,15 @@ tcp_receive(struct tcp_pcb *pcb)
->ooseq. We check the lengths to see which one to
discard. */
if (inseg.len > next->len) {

/* If next segment is the last segment in ooseq
and smaller than inseg, that means it has been
trimmed before to fit our window, so we just
break here. */
if (next->next == NULL) {
break;
}

/* The incoming segment is larger than the old
segment. We replace some segments with the new
one. */
Expand Down

0 comments on commit 574bd6e

Please sign in to comment.