Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for slackware #766

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Add support for slackware #766

merged 1 commit into from
Sep 1, 2023

Conversation

slapcat
Copy link

@slapcat slapcat commented Aug 12, 2023

  • added http source (works with 15.0 and current)
  • added slackpkg manager (upgrade/clean fail if there are not any packages to upgrade/clean)

@slapcat
Copy link
Author

slapcat commented Aug 15, 2023

Hey folks - Anything else I need to do from my end to trigger the tests?

My first commit failed because of a different git user email than what I signed the DCO with. I corrected it, but not sure if that is enough to resolve it or if a new PR is needed.

@stgraber
Copy link
Member

Still a slight issue with the DCO as Author and Signed-off-by don't line up.

@slapcat
Copy link
Author

slapcat commented Aug 15, 2023 •
edited
Loading

Sorry, I'm not too familiar with the DCO part. I tried to change the Author for the DCO on the second commit (since I want to use the signed-off-by email) by updating it with git config --global user.email, but this was apparently not enough. Where else can I change it?

@stgraber
Copy link
Member

git commit --amend --author="Author <email>" lets you modify the Author field in git.

@slapcat slapcat force-pushed the main branch 3 times, most recently from da31683 to 424ad5e Compare August 16, 2023 15:06
@slapcat
Copy link
Author

slapcat commented Sep 1, 2023

I think this one is finally ready 😁 can someone please review it?

@slapcat @stgraber
Add support for slackware
d446a23 
- added http source (works with 15.0 and current)
- added slackpkg manager (upgrade/clean fail if there are
  not any packages to upgrade/clean)

Signed-off-by: Jake Nabasny <jake@nabasny.com>
@stgraber stgraber merged commit e302a95 into lxc:main Sep 1, 2023
8 checks passed
@slapcat slapcat mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slapcat @stgraber