Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shrink a qterminal window and right-click Copy.Link.Address can produce invalid URLs #805

Closed
guiverc opened this issue Mar 12, 2021 · 3 comments
Labels

Comments

@guiverc
Copy link

guiverc commented Mar 12, 2021

If you shrink the qterminal window, then right-click COPY.LINK.ADDRESS of a URL on the window, the URL that gets to the clipboard maybe incomplete

Expected Behavior

I'd expect either

  • the correct URL is copied
  • it refuses to copy the URL since it's no longer valid (not all shown)

Instead if copies the portion of it that is visible (if long, it may appear on multiple lines and it isn't always obvious it's incomplete on screen)

Of course I'd love for it the still COPY the URL as it originally appeared on screen, but if that isn't possible (due to a window re-size), I'd rather have it copy nothing/do-nothing

Current Behavior

Originally noticed on Lubuntu hirsute. See https://bugs.launchpad.net/ubuntu/+source/qterminal/+bug/1918858

I ran a script that creates a file, then view the file with cat

Issue 673 of the Ubuntu Weekly Newsletter is here! Covering the week of February 28 - March 6, 2021 https://wiki.ubuntu.com/UbuntuWeeklyNewsletter/Issue673```

Key bit I watched is "UbuntuWeeklyNewsletter"

On re-sizing the window it that part fo the text became
"UbuntuWewsletter"
re-size again
"Ubuntwsletter"
etc, each time with the copied LINK becoming shorter (& useless), ie.
"https://wikeklynewsletter/Issue673"

##### Possible Solution
<!--- Not obligatory, but suggest a fix/reason for the bug,                --->
<!--- or ideas how to implement the addition or change                     --->

##### Steps to Reproduce (for bugs)

1.  Open qterminal (decent size)
2.  `cat /file` (or anything with a URL on it, a `echo https://wiki.ubuntu.com/UbuntuWeeklyNewsletter/Issue673` would work
3.  right-click & copy.link.address (all good)
4.  reduce window size (so the link isn't all shown)
5.  right-click & copy.link.address (no longer valid)

##### Context
Refer to the launchpad error.
On tuesday morning I ran a script that generates a file for pasting online.  I `cat` the generated file , but forgot to paste to all sites.
The next day (wednesday) I noticed I didn't paste everywhere, I went to the tab where I do UWN work & copy-link & pasted the URL knowing nothing had changed (never occurred to me a re-size of window changes the contents of qterminal functions)
Today I notice the paste done wednesday or in fact today is now an invalid URL.  I need to `cat` the file again to see the URL on my re-sized qterminal window

##### System Information
                                                       --->
* Distribution & Version: Lubuntu hirsute & opensuse tumbleweed (2021-02-22)
* Kernel: 5.10.0-14 & 5.10.16-1
* Qt Version: 5.15.2 & 5.15.2
* qtermwidget Version: libqtermwidget5-0:amd64(0.16.1-1ubuntu1)
* lxqt-build-tools Version: 
* Package version: 0.16.1-1ubuntu1 & 0.16.1-1.3
@guiverc
Copy link
Author

guiverc commented Mar 12, 2021

Same occurs in Fedora 33
LXQt 0.15.0
Qt 5.15.2
kernel 5.10.16

@tsujan tsujan added the bug label Dec 13, 2024
@tsujan
Copy link
Member

tsujan commented Dec 13, 2024

After checking the code, it seems to me that this is caused by #76.

@tsujan
Copy link
Member

tsujan commented Dec 13, 2024

Opened lxqt/qtermwidget#576, which might remain open indefinitely, unless someone implements text wrapping before the last prompt. Closing…

@tsujan tsujan closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants