Fix references to undefined

lxsmnsyc · Jan 27, 2024 · 282ffea · 282ffea
1 parent 0429b66
commit 282ffea
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 20 deletions.
diff --git a/packages/forgetti/src/core/is-constant.ts b/packages/forgetti/src/core/is-constant.ts
@@ -1,10 +1,10 @@
 import type * as babel from '@babel/core';
 import * as t from '@babel/types';
-import { isNestedExpression, shouldSkipNode, isPathValid } from './checks';
-import type OptimizerScope from './optimizer-scope';
+import { isNestedExpression, isPathValid, shouldSkipNode } from './checks';
 import getForeignBindings, { isForeignBinding } from './get-foreign-bindings';
-import type { ComponentNode, StateContext } from './types';
 import { getHookCallType } from './get-hook-call-type';
+import type OptimizerScope from './optimizer-scope';
+import type { ComponentNode, StateContext } from './types';
 
 interface OptimizerInstance {
   ctx: StateContext;
@@ -36,22 +36,14 @@ function isIdentifierConstant(
   path: babel.NodePath,
   node: t.Identifier,
 ): boolean {
-  switch (node.name) {
-    case 'undefined':
-    case 'NaN':
-    case 'Infinity':
-      return true;
-    default: {
-      if (isForeignBinding(instance.path, path, node.name)) {
-        return true;
-      }
-      const binding = path.scope.getBindingIdentifier(node.name);
-      if (binding) {
-        return instance.scope.hasConstant(binding);
-      }
-      return true;
-    }
+  if (isForeignBinding(instance.path, path, node.name)) {
+    return true;
   }
+  const binding = path.scope.getBindingIdentifier(node.name);
+  if (binding) {
+    return instance.scope.hasConstant(binding);
+  }
+  return true;
 }
 
 function isMemberExpressionConstant(

diff --git a/packages/forgetti/src/core/simplify-expressions.ts b/packages/forgetti/src/core/simplify-expressions.ts
@@ -1,5 +1,5 @@
-import * as t from '@babel/types';
 import type * as babel from '@babel/core';
+import * as t from '@babel/types';
 import type { ComponentNode } from './types';
 
 type LiteralState = 'truthy' | 'falsy' | 'nullish' | 'indeterminate';
@@ -82,7 +82,7 @@ export function simplifyExpressions(path: babel.NodePath<ComponentNode>): void {
         switch (p.node.operator) {
           case 'void': {
             if (state !== 'indeterminate') {
-              p.replaceWith(t.identifier('undefined'));
+              p.replaceWith(t.unaryExpression('void', t.numericLiteral(0)));
             }
             break;
           }