Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suservo: Support more than two Urukuls per Sampler #1339

Open
dnadlinger opened this issue Jul 7, 2019 · 3 comments · May be fixed by #1467 or #1782
Open

suservo: Support more than two Urukuls per Sampler #1339

dnadlinger opened this issue Jul 7, 2019 · 3 comments · May be fixed by #1467 or #1782
Labels
area:su-servo Sampler-Urukul-Servo

Comments

@dnadlinger
Copy link
Collaborator

Currently, the SUServo gateware/driver assume that there are two Urukuls per servo instance, and one Sampler. This isn't unreasonable, as it corresponds to 8 ADC channels and 8 DDSes.

However, in typical experiments, many laser beamlines will end up having more than one wavelength/frequency component, and hence on average more than one DDS channel per ADC channel.

We already support choosing the source ADC channel for each profile, so support for an unequal number of ADC and DDS channels should not be too hard to add.

@jordens: Any comments regarding this? I had a quick look at splitting w.channel into w.adc_channel and w.dds_channel, and it doesn't seem too bad, but I'm not sure whether I've noticed all the intricacies of the pipelined design.
@dnadlinger dnadlinger added the area:su-servo Sampler-Urukul-Servo label Jul 7, 2019
@jordens
Copy link
Member

jordens commented Jul 16, 2019

This should be doable. It will lengthen the cycle accordingly but I don't see any road blocks.

@dnadlinger
Copy link
Collaborator Author

We've got this implemented and working; need to find some time to clean up the changes.

@dtcallcock
Copy link

Great to hear. We definitely plan on using this.

@jordens jordens mentioned this issue Dec 2, 2019
Merged
8 tasks
This was referenced Jun 16, 2020
Closed
Open
@pmldrmota pmldrmota linked a pull request Nov 17, 2021 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:su-servo Sampler-Urukul-Servo
Projects
None yet
Milestone
No milestone
3 participants
@dnadlinger @jordens @dtcallcock