Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

Field handle lookup happens with every smart_ptr dereference #10

Open
lukehutch opened this issue Aug 21, 2019 · 3 comments
Open

Field handle lookup happens with every smart_ptr dereference #10

lukehutch opened this issue Aug 21, 2019 · 3 comments

Comments

@lukehutch
Copy link

Currently Java field lookup happens on every smart pointer dereference in handle.h. This is slow, and only needs to be done once per class. The field reference can be held using a global reference:

http://journals.ecs.soton.ac.uk/java/tutorial/native1.1/implementing/refs.html

@m0glan
Copy link
Owner

m0glan commented Aug 21, 2019

Promise I'll look at all these in the weekend. If you have the time, please modify and creat pull requests accordingly

@lukehutch
Copy link
Author

I have to figure out how to generate a PR from a cherry picked change, but the fix for this is here:

2b3995b

@gytwowo
Copy link

gytwowo commented Sep 29, 2019

Did this need C++ library of pcl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants