Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function maybe better than class #10

Open
geminiyellow opened this issue Oct 23, 2018 · 2 comments
Open

function maybe better than class #10

geminiyellow opened this issue Oct 23, 2018 · 2 comments

Comments

@geminiyellow
Copy link

hi @m0ngr31 thanks for your great work.

but you know, when somebody use react-native-web, like me, hope detect the device type when resize window. so, a function, check current screen/window size , maybe better than now, only check once when init the library.

@Fsarmento
Copy link

Even in react-native, if the device changes orientation, width and height do not update. Dimensions have an addEventListener method that fires every time a property of "window" or "screen" changes. It could be used to guarantee that width and height are always correct.

@m0ngr31
Copy link
Owner

m0ngr31 commented Jan 16, 2020

I just wrote a proof of concept: #14

Let me know if you think that'd work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants