Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert TASK_WORKSPACE_DIRECTORY is included in env_to_inherit #34

Closed
maronuu opened this issue Jun 23, 2023 · 2 comments
Closed

Assert TASK_WORKSPACE_DIRECTORY is included in env_to_inherit #34

maronuu opened this issue Jun 23, 2023 · 2 comments
Assignees
@maronuu

Comments

@maronuu
Copy link
Collaborator

maronuu commented Jun 23, 2023

What

Assert TASK_WORKSPACE_DIRECTORY is included in env_to_inherit.

Currently, when env_to_inherit is None (by default), TASK_WORKSPACE_DIRECTORY is automatically added.
However, when user specifies some values for it, there is no guarantee that TASK_WORKSPACE_DIRECTORY is included.
Since TASK_WORKSPACE_DIRECTORY is essential, it should be asserted.
@maronuu maronuu self-assigned this Jun 25, 2023
@maronuu
Copy link
Collaborator Author

maronuu commented Feb 26, 2024

Deprecated after #39 is accepted.

@maronuu
Copy link
Collaborator Author

maronuu commented Feb 29, 2024

The specific environment variable TASK_WORKSPACE_DIRECTORY is no longer required in kannon library.
Instead, users are responsible to inheriting required env vars via env_to_inherit if they use env vars in some ways.

@maronuu maronuu closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maronuu maronuu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maronuu