Merge pull request #5151 from mP1/feature/SpreadsheetMetadata-checkPr…

…opertyName-refactor SpreadsheetMetadata.checkPropertyName refactor
mP1 · Sep 21, 2024 · b97b4d0 · b97b4d0
2 parents c92a419 + 7b02ad1
commit b97b4d0
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/src/main/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadata.java b/src/main/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadata.java
@@ -220,9 +220,9 @@ public Optional<SpreadsheetName> name() {
      * require creating a new {@link SpreadsheetMetadata}.
      */
     public final <V> Optional<V> get(final SpreadsheetMetadataPropertyName<V> propertyName) {
-        checkPropertyName(propertyName);
-
-        return this.getOrGetDefaults(propertyName);
+        return this.getOrGetDefaults(
+                checkPropertyName(propertyName)
+        );
     }
 
     /**
@@ -324,9 +324,8 @@ private TextStyle getStyleOrEmpty() {
      */
     public final <V> SpreadsheetMetadata set(final SpreadsheetMetadataPropertyName<V> propertyName,
                                              final V value) {
-        checkPropertyName(propertyName);
         return this.set0(
-                propertyName,
+                checkPropertyName(propertyName),
                 propertyName.checkValue(value) // necessary because absolute references values are made relative
         );
     }
@@ -418,15 +417,15 @@ private static void reportDuplicateProperty(final SpreadsheetMetadataPropertyNam
      * Removes a possibly existing property returning a {@link SpreadsheetMetadata} without.
      */
     public final SpreadsheetMetadata remove(final SpreadsheetMetadataPropertyName<?> propertyName) {
-        checkPropertyName(propertyName);
-
-        return this.remove0(propertyName);
+        return this.remove0(
+                checkPropertyName(propertyName)
+        );
     }
 
     abstract SpreadsheetMetadata remove0(final SpreadsheetMetadataPropertyName<?> propertyName);
 
-    private static void checkPropertyName(final SpreadsheetMetadataPropertyName<?> propertyName) {
-        Objects.requireNonNull(propertyName, "propertyName");
+    private static <T> SpreadsheetMetadataPropertyName<T> checkPropertyName(final SpreadsheetMetadataPropertyName<T> propertyName) {
+        return Objects.requireNonNull(propertyName, "propertyName");
     }
 
     // setOrRemove......................................................................................................