From b92e6cadd59d695a2fb199dbe6326c4200e07771 Mon Sep 17 00:00:00 2001 From: Miroslav Pokorny Date: Thu, 19 Sep 2024 17:27:12 +1000 Subject: [PATCH] SpreadsheetMetadataPropertyNameXXXTest.testCheckValue prefix --- ...dsheetMetadataPropertyNameEmailAddressTestCase.java | 2 +- ...etMetadataPropertyNameExpressionNumberKindTest.java | 7 +++++-- ...readsheetMetadataPropertyNameFrozenColumnsTest.java | 2 +- .../SpreadsheetMetadataPropertyNameFrozenRowsTest.java | 2 +- ...preadsheetMetadataPropertyNameRoundingModeTest.java | 2 +- ...readsheetMetadataPropertyNameSpreadsheetIdTest.java | 7 +++++-- ...adsheetMetadataPropertyNameSpreadsheetNameTest.java | 7 +++++-- .../meta/SpreadsheetMetadataPropertyNameStyleTest.java | 2 +- .../meta/SpreadsheetMetadataPropertyNameTestCase.java | 6 +++--- .../SpreadsheetMetadataPropertyNameViewportTest.java | 10 +++++----- 10 files changed, 28 insertions(+), 19 deletions(-) diff --git a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameEmailAddressTestCase.java b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameEmailAddressTestCase.java index d0fb242a2..79f8db67a 100644 --- a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameEmailAddressTestCase.java +++ b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameEmailAddressTestCase.java @@ -29,7 +29,7 @@ public abstract class SpreadsheetMetadataPropertyNameEmailAddressTestCase { @Test - public void testInvalidExpressionNumberKindFails() { - this.checkValueFails("invalid", "Expected ExpressionNumberKind, but got \"invalid\" for \"expression-number-kind\""); + public void testCheckValueWithInvalidExpressionNumberKindFails() { + this.checkValueFails( + "invalid", + "Expected ExpressionNumberKind, but got \"invalid\" for \"expression-number-kind\"" + ); } @Test diff --git a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameFrozenColumnsTest.java b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameFrozenColumnsTest.java index bef63cac4..e549541bd 100644 --- a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameFrozenColumnsTest.java +++ b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameFrozenColumnsTest.java @@ -27,7 +27,7 @@ public final class SpreadsheetMetadataPropertyNameFrozenColumnsTest extends SpreadsheetMetadataPropertyNameTestCase { @Test - public void testInvalidSpreadsheetColumnRangeReferenceFails() { + public void testCheckValueWithInvalidSpreadsheetColumnRangeReferenceFails() { this.checkValueFails( SpreadsheetSelection.parseColumnRange("C:D"), "Range must begin at 'A', but got C:D for \"frozen-columns\"" diff --git a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameFrozenRowsTest.java b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameFrozenRowsTest.java index d9a8e46bf..78efeca37 100644 --- a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameFrozenRowsTest.java +++ b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameFrozenRowsTest.java @@ -28,7 +28,7 @@ public final class SpreadsheetMetadataPropertyNameFrozenRowsTest extends SpreadsheetMetadataPropertyNameTestCase { @Test - public void testInvalidSpreadsheetRowRangeReferenceFails() { + public void testCheckValueWithInvalidSpreadsheetRowRangeReferenceFails() { this.checkValueFails( SpreadsheetSelection.parseRowRange("2:3"), "Range must begin at '1', but got 2:3 for \"frozen-rows\"" diff --git a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameRoundingModeTest.java b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameRoundingModeTest.java index 57644c916..70d2dcf10 100644 --- a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameRoundingModeTest.java +++ b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameRoundingModeTest.java @@ -26,7 +26,7 @@ public final class SpreadsheetMetadataPropertyNameRoundingModeTest extends SpreadsheetMetadataPropertyNameTestCase { @Test - public void testInvalidRoundingModeFails() { + public void testCheckValueWithInvalidRoundingModeFails() { this.checkValueFails("invalid", "Expected RoundingMode, but got \"invalid\" for \"rounding-mode\""); } diff --git a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameSpreadsheetIdTest.java b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameSpreadsheetIdTest.java index 01f7fa7bb..9901974a8 100644 --- a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameSpreadsheetIdTest.java +++ b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameSpreadsheetIdTest.java @@ -26,8 +26,11 @@ public final class SpreadsheetMetadataPropertyNameSpreadsheetIdTest extends SpreadsheetMetadataPropertyNameTestCase { @Test - public void testInvalidSpreadsheetIdFails() { - this.checkValueFails("123-invalid", "Expected SpreadsheetId, but got \"123-invalid\" for \"spreadsheet-id\""); + public void testCheckValueWithInvalidSpreadsheetIdFails() { + this.checkValueFails( + "123-invalid", + "Expected SpreadsheetId, but got \"123-invalid\" for \"spreadsheet-id\"" + ); } @Test diff --git a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameSpreadsheetNameTest.java b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameSpreadsheetNameTest.java index bb22d3d80..8f66d7d3b 100644 --- a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameSpreadsheetNameTest.java +++ b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameSpreadsheetNameTest.java @@ -26,8 +26,11 @@ public final class SpreadsheetMetadataPropertyNameSpreadsheetNameTest extends SpreadsheetMetadataPropertyNameTestCase { @Test - public void testInvalidSpreadsheetNameFails() { - this.checkValueFails("\r", "Expected SpreadsheetName, but got \"\\r\" for \"spreadsheet-name\""); + public void testCheckValueWithInvalidSpreadsheetNameFails() { + this.checkValueFails( + "\r", + "Expected SpreadsheetName, but got \"\\r\" for \"spreadsheet-name\"" + ); } @Test diff --git a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameStyleTest.java b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameStyleTest.java index fa91b7efa..9d9528871 100644 --- a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameStyleTest.java +++ b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameStyleTest.java @@ -27,7 +27,7 @@ public final class SpreadsheetMetadataPropertyNameStyleTest extends SpreadsheetMetadataPropertyNameTestCase { @Test - public void testCheckEmptyTextStyle() { + public void testCheckValueEmptyTextStyle() { this.checkValue(TextStyle.EMPTY); } diff --git a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameTestCase.java b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameTestCase.java index bbe59f86f..9fa6d3851 100644 --- a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameTestCase.java +++ b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameTestCase.java @@ -89,19 +89,19 @@ public final void testSpreadsheetMetadataJsonRoundtrip() { } @Test - public final void testCheckValueNullFails() { + public final void testCheckValueWithNullFails() { this.checkValueFails(null, "Missing value, but got null for " + CharSequences.quote(this.createName().value())); } @Test - public final void testCheckValueInvalidFails() { + public final void testCheckValueWithInvalidFails() { this.checkValueFails(this, "Expected " + this.propertyValueType() + ", but got " + this + " for " + CharSequences.quote(this.createName().value())); } @Test - public final void testCheckInvalidValueFails2() { + public final void testCheckValueWithInvalidValueFails2() { final StringBuilder value = new StringBuilder("123abc"); this.checkValueFails(value, "Expected " + this.propertyValueType() + ", but got \"123abc\" for " + CharSequences.quote(this.createName().value())); diff --git a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameViewportTest.java b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameViewportTest.java index c60d38ffb..e26c8e141 100644 --- a/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameViewportTest.java +++ b/src/test/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataPropertyNameViewportTest.java @@ -32,7 +32,7 @@ public final class SpreadsheetMetadataPropertyNameViewportTest extends Spreadshe SpreadsheetViewport> { @Test - public void testCheckCellRange() { + public void testCheckValueWithCellRange() { this.checkValue( SpreadsheetSelection.A1.viewportRectangle(100, 40) .viewport() @@ -46,7 +46,7 @@ public void testCheckCellRange() { } @Test - public void testCheckColumn() { + public void testCheckValueWithColumn() { this.checkValue( SpreadsheetSelection.A1.viewportRectangle(100, 40) .viewport() @@ -60,7 +60,7 @@ public void testCheckColumn() { } @Test - public void testCheckLabel() { + public void testCheckValueWithLabel() { this.checkValue( SpreadsheetSelection.A1.viewportRectangle(100, 40) .viewport() @@ -74,7 +74,7 @@ public void testCheckLabel() { } @Test - public void testCheckRow() { + public void testCheckValueWithRow() { this.checkValue( SpreadsheetSelection.A1.viewportRectangle(100, 40) .viewport() @@ -88,7 +88,7 @@ public void testCheckRow() { } @Test - public void testInvalidValueFails() { + public void testCheckValueWithInvalidFails3() { this.checkValueFails( "invalid", "Expected SpreadsheetViewport, but got \"invalid\" for \"viewport\""