Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing criteria search types #48

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fix missing criteria search types #48

merged 3 commits into from
Jul 24, 2024

Conversation

brysontyrrell
Copy link
Collaborator

@brysontyrrell brysontyrrell commented Jul 24, 2024 •
edited
Loading

Add the following search types to the criteria object:

  • member of
  • not member of

Fixes #41

@brysontyrrell brysontyrrell linked an issue Jul 24, 2024 that may be closed by this pull request
[Bug] ClassicAdvancedComputerSearch error when scope includes 'member of' #41
Closed
@brysontyrrell brysontyrrell added the bug Something isn't working label Jul 24, 2024
@brysontyrrell brysontyrrell requested a review from burnsburns July 24, 2024 03:27
@burnsburns burnsburns merged commit 24547f5 into main Jul 24, 2024
2 checks passed
@burnsburns burnsburns deleted the fix-criteria-missing-member-of branch July 24, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnsburns burnsburns burnsburns approved these changes

Assignees

@burnsburns burnsburns

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] ClassicAdvancedComputerSearch error when scope includes 'member of'
2 participants
@brysontyrrell @burnsburns