-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for trace infinity loop in exception handling #66
Conversation
I copied the workaround from macopedia#54 because the pr is not yet splitted and i needed the functionality.
Ive got the counter solution, looks ok, but why did you also change the dirname part? |
Oops, didnt see this while copying. I'll fix it |
magmi/inc/magmi_engine.php
Outdated
@@ -409,7 +409,7 @@ public function getExceptionTrace($tk, &$traces) | |||
} | |||
} | |||
// simple max trace depth fix | |||
if (++$counter % 20) { | |||
if (++$counter % 20 == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets have === just for a sake of being clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :)
thanks! |
I copied the workaround from #54 because the pr is not yet splitted and i needed the functionality.