Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-pythran: add py312 subport #21909

Closed
wants to merge 1 commit into from

Conversation

erikbs
Copy link
Contributor

@erikbs erikbs commented Dec 22, 2023

Description

Backporting #258ab9a from master (I skipped the test files, since they are not run by MacPorts). MacPorts will install the py312 subport successfully without this patch, but one quickly runs into runtime exceptions. It should be removed the next time the port version is updated.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.9.5 13F1911 x86_64
Xcode 6.2 6C131e

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Testing the binaries: I tested the binary indirectly by successfully building SciPy with it.

@macportsbot
Copy link

Notifying maintainers:
@reneeotten for port py-pythran.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port labels Dec 22, 2023
@barracuda156
Copy link
Contributor

@erikbs This won’t break building of scipy with distutils, right?

@reneeotten
Copy link
Contributor

reneeotten commented Dec 22, 2023

@erikbs I will add py312 subports for Python ports once I have verified they work. I am/was assuming you do before you submit PRs but from PR #21553 it's clear that didn't happen. So no point submitting PRs for adding py312 subports for Python ports that I maintain.

@erikbs
Copy link
Contributor Author

erikbs commented Dec 23, 2023

@erikbs This won’t break building of scipy with distutils, right?

@barracuda156 It should not. They have simply added try-except blocks that first try to import from distutils, then setuptools if distutils failed.

@erikbs
Copy link
Contributor Author

erikbs commented Dec 23, 2023

@erikbs I will add py312 subports for Python ports once I have verified they work. I am/was assuming you do before you submit PRs but from PR #21553 it's clear that didn't happen. So no point submitting PRs for adding py312 subports for Python ports that I maintain.

@reneeotten Sorry, my intention has not been to put extra work on you. I do not want to disturb if you get the py312 subports done more efficiently alone.

Regarding PR #21553 it was a draft and I did leave the testing checkboxes unchecked. If port content reports that there are binaries, I always try to run them, preferably with options to verify that they actually work. If I have no clue how to use the tool (e.g. if the package is only a dependency for one I need), I leave the checkbox alone and usually leave a note about what I did (as in this case, at the very bottom of the first comment). Also I usually import the package, dir() it and try using a couple of things from it.

I will admit that in this case I failed to reflect enough on the fact that the output of port content was too short, I assumed that it was fine since it contained the same files as the py311 subport you added last year, which was my reference.

@reneeotten
Copy link
Contributor

waiting for the new release before updating the port (see: serge-sans-paille/pythran#2149 and serge-sans-paille/pythran#2167)

@reneeotten reneeotten closed this Jan 7, 2024
@erikbs
Copy link
Contributor Author

erikbs commented Jan 7, 2024

Apparently the py312 subport was added last week (but without the patch that makes it work), so I close this one. See #22080 for the 0.15.0 update.

@erikbs erikbs deleted the feature/py312-pythran branch January 7, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

4 participants