Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce possibility to install VictoriaMetrics or Prometheus #222

Merged
merged 10 commits into from
Nov 25, 2021

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Nov 24, 2021

PR Description

│ Error: Forbidden attribute key in "manifest" value
│
│   with kubernetes_manifest.prometheus-operator_crds["alertmanagerconfigs.monitoring.coreos.com"],
│   on eks-prometheus-operator-crds.tf line 21, in resource "kubernetes_manifest" "prometheus-operator_crds":
│   21: resource "kubernetes_manifest" "prometheus-operator_crds" {
│
│ 'status' attribute key is not allowed in manifest configuration

It describes here hashicorp/terraform-provider-kubernetes#1428.

That's why I switched from kubernetes provider to kubectl provider. It supports additional functionality https://github.com/gavinbunney/terraform-provider-kubectl/blob/15de61bb38d402fff44db5ea6b1cc8d43aea579a/docs/resources/kubectl_manifest.md#ignore-manifest-fields

Fixes #145

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov requested review from halfb00t, khalezin, p1gmale0n and a team November 24, 2021 08:39
docs/FAQ.md Outdated Show resolved Hide resolved
docs/FAQ.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov merged commit fbadca7 into main Nov 25, 2021
@mglotov mglotov deleted the feat/victoriametrics branch November 25, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: have possibility to install VictoriaMetrics instead of Prometheus
3 participants