Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow unsecure authentication cookies in dev #42

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

vinceh121
Copy link
Contributor

Describe your changes

Checklist before requesting a review

  • Commit names follow the Conventional Commits convention
  • I have checked the entire code before submitting it
  • I have updated the documentation related to my commits
  • My code does not generate errors

Copy link
Owner

@maelgangloff maelgangloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to make development easier with a hostname other than localhost.
Thanks @vinceh121 !

config/services.yaml Outdated Show resolved Hide resolved
src/Security/JWTAuthenticator.php Outdated Show resolved Hide resolved
src/Security/JWTAuthenticator.php Outdated Show resolved Hide resolved
@maelgangloff maelgangloff added the enhancement New feature or request label Aug 19, 2024
@maelgangloff maelgangloff added this to the v0.3.0 milestone Aug 19, 2024
vinceh121 and others added 3 commits August 19, 2024 21:21
Co-authored-by: Maël Gangloff <contact@maelgangloff.fr>
Signed-off-by: Vincent <contact@vinceh121.me>
Co-authored-by: Maël Gangloff <contact@maelgangloff.fr>
Signed-off-by: Vincent <contact@vinceh121.me>
Co-authored-by: Maël Gangloff <contact@maelgangloff.fr>
Signed-off-by: Vincent <contact@vinceh121.me>
Copy link
Owner

@maelgangloff maelgangloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinceh121 !

@maelgangloff maelgangloff merged commit ec72de1 into maelgangloff:master Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants