Skip to content

Commit

Permalink
Merge pull request #7 from magefan/7972-update-config
Browse files Browse the repository at this point in the history
Update system.xml & config.xml
  • Loading branch information
magefan authored May 2, 2023
2 parents d809396 + 9275550 commit 03d26b2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
10 changes: 5 additions & 5 deletions etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Config:etc/system_file.xsd">
<system>
<section id="mfrocketjavascript" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="10" translate="label">
<section id="mfrocketjavascript" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="11522083660" translate="label">
<label>Rocket JavaScript</label>
<tab>magefan</tab>
<resource>Magefan_RocketJavaScript::config_magefan_rocketjavascript</resource>
Expand All @@ -27,24 +27,24 @@
<label>Product Key</label>
<frontend_model>Magefan\Community\Block\Adminhtml\System\Config\Form\ProductKeyField</frontend_model>
</field>
<field id="enable_deferred_javascript" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="29" translate="label" type="select">
<field id="enable_deferred_javascript" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="29" translate="label" type="select" canRestore="1">
<label>Enabled Deferred JavaScript</label>
<comment>If enabled all JavaScript on storefront will be moved to the end of the page.</comment>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
</field>
<field id="disallowed_pages_for_deferred_js" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="30" translate="label" type="textarea">
<field id="disallowed_pages_for_deferred_js" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="30" translate="label" type="textarea" canRestore="1">
<label>Disallowed Pages for Deferred JavaScript</label>
<depends>
<field id="enable_deferred_javascript">1</field>
</depends>
<comment>Enter page patches each in a new line. "*" means any path, you can use it at the beginning or end.</comment>
</field>
<field id="enable_js_bundling_optimization" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="30" translate="label" type="select">
<field id="enable_js_bundling_optimization" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="30" translate="label" type="select" canRestore="1">
<label>Enable JavaScript Bundling Optimization</label>
<comment>Please note that this option only works with enabled JavaScript Bundling (Configuration > Advanced > Developer > JavaScript Settings > Enable JavaScript Bundling).</comment>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
</field>
<field id="included_in_bundling" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="40" translate="label" type="textarea">
<field id="included_in_bundling" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="40" translate="label" type="textarea" canRestore="1">
<label>Included In Bundling</label>
<depends>
<field id="enable_js_bundling_optimization">1</field>
Expand Down
6 changes: 4 additions & 2 deletions etc/config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,13 @@
<default>
<mfrocketjavascript>
<general>
<mfmodule>RocketJavaScript</mfmodule>
<mftype>1</mftype>
<enable_deferred_javascript>1</enable_deferred_javascript>
<disallowed_pages_for_deferred_js>checkout/*
onestepcheckout/*
</disallowed_pages_for_deferred_js>
<enable_js_bundling_optimization>1</enable_js_bundling_optimization>
<included_in_bundling>jquery.min.js
mage/common.min.js
mage/dataPost.min.js
Expand Down Expand Up @@ -130,8 +134,6 @@ Magento_Customer/template/authentication-popup.html
Magento_Ui/templates/collection.html
Magento_Ui/template/messages.html
Magento_Captcha/template/checkout/captcha.html</included_in_bundling>
<mfmodule>RocketJavaScript</mfmodule>
<mftype>1</mftype>
</general>
</mfrocketjavascript>
</default>
Expand Down

0 comments on commit 03d26b2

Please sign in to comment.