Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong wordlist on tab completion #270

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

kernelPanic0x
Copy link
Contributor

@kernelPanic0x kernelPanic0x commented Nov 9, 2024

This should fix the wrong wordlist selection. I also added more tests for wordlist choosing and wordlist selection when autocompleting.

Closes #269

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.52%. Comparing base (390cd42) to head (edc2cf9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   37.75%   37.52%   -0.23%     
==========================================
  Files          19       19              
  Lines        3218     3219       +1     
==========================================
- Hits         1215     1208       -7     
- Misses       2003     2011       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@felinira felinira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the additional tests. Looking good :)

src/core/wordlist.rs Outdated Show resolved Hide resolved
@felinira
Copy link
Collaborator

felinira commented Nov 9, 2024

If you add a "Closes #269" to a commit messages / the initial PR message it will auto-close the issue when it's merged :)

@felinira felinira enabled auto-merge (rebase) November 9, 2024 15:42
@felinira felinira merged commit b6c7f6b into magic-wormhole:main Nov 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wormhole completion suggestion seems to get wrong wordlist
2 participants