This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Adds customViewWrapper optional to Magic SDK to Permit External Actions
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethella
reviewed
Mar 19, 2024
| // MARK: - External Dismiss WebView | ||
| public func externalDismissLoginView() { | ||
| do { | ||
| try self.provider.overlay.detachWebViewFromCustomView() |
There was a problem hiding this comment.
Would this call recycle webview?
There was a problem hiding this comment.
Yes, that's the point, the developer wants to remove the WebView from the view hierarchy. See his comments here.
There was a problem hiding this comment.
I considered potentially naming this method something like authOnlyExternalDismissLoginView 🤔 Perhaps add some more comments to inform web3 devs that they should not use this method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
customViewWrapperoptional parameter to the Magic SDK to allow developers to pass in their ownUIViewControllerand permit them to setup custom actions like dismiss Magic's Webview with external methods likeexternalDismissLoginViewas requested in PR #39