Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code. #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove dead code. #5

wants to merge 4 commits into from

Conversation

jjhbw
Copy link

@jjhbw jjhbw commented Jun 27, 2022

Just read your paper. Very interesting method! Thanks for open sourcing such a comprehensive codebase.

My lab is interested in trying it on our own dataset for a classification task that we've been working on. I was working through your code to get a feel for how it works, and my IDE detected a few unused lines.

Maybe left over lines from a refactor? I deleted the lines in question in this MR to point them out. I have no idea whether they actually need to be removed, or whether they are unreachable by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant