Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Open" with "Update" on update screen #124

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Petrprogs
Copy link
Contributor

No description provided.

@Feodor0090
Copy link
Contributor

Feodor0090 commented Aug 8, 2023

That's an interesting case.

If you check how it works, it's not difficult to see that "update" system is actually a telemetry reporter, which send your model, version and functions which you used and receives an arbitrary text/url to show. One (not single) use case of this - check your version server-side and return update prompt. So "Open" button is here to cover other cases, since "open" is the most universal text for such button.

Anyways, MMaps are running for ~3 monthes already and we still didn't need to use this for anything but update prompts. So, may be it really worth to apply this... Maybe not... Dunno.

@Petrprogs
Copy link
Contributor Author

The final decision is yours :)

@Feodor0090
Copy link
Contributor

@shinovon decide something here

Copy link
Contributor

@Feodor0090 Feodor0090 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 weeks passed and i still have no idea how we can use this for anything else but updates. Merging because why not.

@Feodor0090 Feodor0090 merged commit fce785c into mahomaps:main Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants