Make geo classes less linked and implement build without them #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinovon
reviewed
Sep 11, 2023
proguard.basecfg
Outdated
| @@ -27,4 +27,5 @@ | |||
| } | |||
|
|
|||
| -keep public class * extends javax.microedition.midlet.MIDlet | |||
| -keep public class * extends mahomaps.map.ILocationAPI | |||
There was a problem hiding this comment.
Доправь тогда как надо. По идее, надо только имя запретить трогать.
There was a problem hiding this comment.
Перечитал все, понял почему так надо
| @@ -20,7 +14,7 @@ public class GeoUpdateThread extends Thread { | |||
| * Состояние получения геопозиции. Одно из state-значений. | |||
| */ | |||
| public int state; | |||
| private LocationAPI locationAPI; | |||
| private ILocationAPI locationAPI; | |||
shinovon
previously approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: