Merge alpha-punch and main into alpha
#1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The faucet and daemon upgrades did not work correctly because the release type was hard coded to `ReleaseType::Safenode` and was not changed when this code was refactored.
The ARM builds are done using a tool called `cross`, which uses Docker containers, and therefore the compile-time variables need to be passed to the containers. This is done using the `CROSS_CONTAINER_OPTS` variable. I tested this locally to confirm the desired effect.
This change exists just to generate a new version number. We can remove it if necessary.
There was an issue with the script always applying 0 for the pre-release identifier. We got into a situation where it actually needed to be incremented by 1, because there was already a crate published at the 0 version. Added some text output to help clarify what the script is doing. Also tidied the style by consistently applying Bash syntax (as opposed to POSIX compatible) and a tab size of 2.
Just removed a few words to try and effect another change in `sn_client`, to get a new version. This crate has already been published and references an older version of `sn_protocol`, which is causing a problem because `sn_cli` is referencing a newer version of it.
Again, these changes are just to effect a release. A change to the release workflow also removes testing the environment variable and re-exporting it. On the last build I ran, it appears to have worked as expected, where previously it didn't. Doesn't really make any sense.
Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action) from 5.4.5 to 6.0.0. - [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md) - [Commits](wagoid/commitlint-github-action@5ce82f5...3c75220) --- updated-dependencies: - dependency-name: wagoid/commitlint-github-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This would allow users of this struct to override the default stdout printing and instead provide thier own custom impl
The binary name will be `node-launchpad`, but the crate is named consistently along with the other crates in the workspace (including the use of underscores rather than hyphens).
The node manager `start` command has an `--interval` argument that can be used as a time-based delay between starting nodes. The problem is, the interval would apply to nodes that were already running, which is a waste of time. Now the interval is not applied to those nodes.
These new banners for the node manager are a bit more eye catching, and also fix the incorrect sizes of the previous banners in the `status --details` command.
This was a community feedback request. The reward balance is now output as part of the `status --json` command, which involved adding the field to the information tracked by the registry. BREAKING CHANGE: previously written registry files will not have this new field and so won't deserialize correctly.
Rather than parsing the text-based output of the `status` command, we now switch to using `status --json`, which we can then serialize into `StatusSummary`, and any status can be obtained from there. This prevents breakage when the text output changes.
Due to it being possible to run the node manager status command before any services have been started, the reward balance should be an optional value, since the node's wallet has not been created before it starts.
These tests are no longer passing and it's not completely clear why. In any case, I think they need to be a bit more isolated, and operate on their own local network. At the moment there is not enough time to address that.
The new TUI for the node manager is a new, separate binary that is being added in to the release process. It will have a Github release. For some reason it seems to have became necessary to explicitly call `rustup target` during the artifacts build process. Without doing it, I was getting build errors on macOS.
Use the `try_load_from` mechanism, rather than `try_load`, because the former will not create the wallet directory if it does not exist. The node manager refreshes its registry when it runs commands like `start` and `stop`, which can be running as the root user. The refresh now involves getting the balance of the wallet. Therefore, when `start` ran for the first time, the `try_load` function was creating a directory owned by the root user. This would cause the node to crash because it couldn't write to that directory. A new Clippy warning is also fixed and I removed the superfluous comments around the code it was referring to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the
alpha-punchbranch into thealphabranch, which gets us changes and fixes that were made onalpha-punch, and the resulting release commits that advanced the version numbers.After that, I merged
mainintoalpha, which gets us the most recent changes like the node manager TUI, but with alpha version numbers.We should hopefully be able to do a version bump from here and get a new release which will include the TUI.
I have deliberately used a merge commit here rather than a rebase, because the merge seems more appropriate for preserving the version numbers that were in the release commits on the
alpha-punchbranch.Description
reviewpad:summary