feat: provide autonomi-launcher binary #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacderida
changed the title
The crate is slightly reorganised to accommodate the addition of the launcher binary. It will be useful to have the launcher and TUI tightly coupled, with the same version number. The changes: * Move `node-launchpad` into its own `bin` directory. Shortly the launcher will be added as a directory alongside it. * Since the `Cli` struct was the only thing in the `cli` module, the module can be removed in favour of the struct sitting alongside the TUI binary's `main` module. * Correct misspelled version keys in references. * Tidy dependencies to be sorted alphabetically for easier reference.
This small binary attempts to detect the presence of a terminal executable, then uses it to run the `node-launchpad` TUI inside it. The TUI is downloaded and stored at `~/.local/bin/autonomi-launcher` on Linux/macOS and `%USERPROFILE%\safe\autonomi-launcher.exe` on Windows. Right now, the version it downloads is hard coded to `0.1.0-alpha.0`. This can be changed quite easily once we get a new release. The launcher is added to the release process as a new binary. However, there is a complication not yet dealt with. The `autonomi-launcher` and `node-launchpad` binaries are in the same crate, so the process for uploading assets to Github releases will need to be modified to accommodate that. We can come back to it.
jacderida
force-pushed
the
feat-node_man_tui_launcher
branch
from
d6981b3 to
e93ac2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4173de5 refactor: small reorganisation of launchpad crate
The crate is slightly reorganised to accommodate the addition of the launcher binary. It will be
useful to have the launcher and TUI tightly coupled, with the same version number.
The changes:
node-launchpadinto its ownbindirectory. Shortly the launcher will be added as adirectory alongside it.
Clistruct was the only thing in theclimodule, the module can be removed in favourof the struct sitting alongside the TUI binary's
mainmodule.e93ac2b feat: provide
autonomi-launcherbinaryThis small binary attempts to detect the presence of a terminal executable, then uses it to run the
node-launchpadTUI inside it.The TUI is downloaded and stored at
~/.local/bin/autonomi-launcheron Linux/macOS and%USERPROFILE%\safe\autonomi-launcher.exeon Windows. Right now, the version it downloads is hardcoded to
0.1.0-alpha.0. This can be changed quite easily once we get a new release.The launcher is added to the release process as a new binary. However, there is a complication not
yet dealt with. The
autonomi-launcherandnode-launchpadbinaries are in the same crate, so theprocess for uploading assets to Github releases will need to be modified to accommodate that. We can
come back to it.
Description
reviewpad:summary