feat(nat): add binary to probe for NAT status #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This binary will help a machine figure out its NAT status. For this to work a public machine runs the binary, while a peer asks the public machine for a dial-back.
Comment on lines
+65
to
+75
| let registry = tracing_subscriber::registry().with(tracing_subscriber::fmt::layer()); | ||
| // Use `RUST_LOG` if set, else use the verbosity flag (where `-vvvv` is trace level). | ||
| let _ = if std::env::var_os("RUST_LOG").is_some() { | ||
| registry.with(EnvFilter::from_env("RUST_LOG")).try_init() | ||
| } else { | ||
| let filter = tracing_subscriber::filter::Targets::new().with_target( | ||
| env!("CARGO_BIN_NAME").replace('-', "_"), | ||
| opt.verbose.log_level_filter().as_trace(), | ||
| ); | ||
| registry.with(filter).try_init() | ||
| }; |
There was a problem hiding this comment.
Maybe in a follow up PR can we make use of sn_logging here? I think it will be useful to have the logs inside a single place.
There was a problem hiding this comment.
Yeah, kind of agree, though I think it's quite compact code here that isn't too complex. I didn't think it would be useful to log to files etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This binary will help a machine figure out its NAT status. For this to
work a public machine runs the binary, while a peer asks the public
machine for a dial-back.