fix: use ant_networking for metrics prefix
#2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ant-networking` prefix was incompatible with the new version of Telegraf because it doesn't allow hyphens in the metric name; however, in any case, this shouldn't have had the hyphen, and should actually have remained as `sn_networking`. It was mistakenly renamed, because we wanted to keep the `sn_` prefix in the metric names so that we could change them more gradually. Now we've decided to just go with the `ant_` prefix, so we are also changing the `sn_node` prefix to `ant_node` as part of this commit.
RolandSherwin
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ant-networkingprefix was incompatible with the new version of Telegraf because it doesn't allow hyphens in the metric name; however, in any case, this shouldn't have had the hyphen, and should actually have remained assn_networking.It was mistakenly renamed, because we wanted to keep the
sn_prefix in the metric names so that we could change them more gradually. Now we've decided to just go with theant_prefix, so we are also changing thesn_nodeprefix toant_nodeas part of this commit.