feat: provide new versioning mechanism #2504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacderida
force-pushed
the
feat-node_versioning
branch
2 times, most recently
from
b4a4dd9 to
e566654
Compare
maqi
reviewed
Dec 8, 2024
Implements the versioning scheme that was discussed and agreed. It only uses the version from the `ant-protocol` crate; no keys or other external sources are provided. Only the `MAJOR` and `MINOR` parts of the version are considered. The patch version can advance without being considered. We have discussed changing the version of other crates such that they are synchronised with this protocol version.
jacderida
force-pushed
the
feat-node_versioning
branch
from
e566654 to
aa6f4b4
Compare
maqi
approved these changes
Dec 8, 2024
|
This will be implemented in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the versioning scheme that was discussed and agreed.
It only uses the version from the
ant-protocolcrate; no keys or other external sources are provided. Only theMAJORandMINORparts of the version are considered. The patch version can advance without being considered.We have discussed changing the version of other crates such that they are synchronised with this protocol version.