feat!: use a simple network id to differentiate between network #2508
Conversation
| pub static ref IDENTIFY_NODE_VERSION_STR: String = | ||
| format!( | ||
| "safe/node/{}/{}", | ||
| pub static ref IDENTIFY_NODE_VERSION_STR: RwLock<String> = |
There was a problem hiding this comment.
Why need the extra RwLock ?
same to others
There was a problem hiding this comment.
Because the network_id is now passed as a runtime argument, using --network-id and not an env var that we can fetch here..
RolandSherwin
force-pushed
the
protocol_str
branch
from
5a587cc to
31fbdb5
Compare
RolandSherwin
force-pushed
the
protocol_str
branch
from
31fbdb5 to
e74bfe5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "--peer", | ||
| "/ip4/127.0.0.1/tcp/8080,/ip4/192.168.1.1/tcp/8081", | ||
| "--network-contacts-url", | ||
| "http://localhost:8080", |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
RolandSherwin
force-pushed
the
protocol_str
branch
from
e74bfe5 to
aae44cb
Compare
| let node_data_dir = temp_dir.child("data"); | ||
| node_data_dir.create_dir_all()?; | ||
| let node_logs_dir = temp_dir.child("logs"); | ||
| node_logs_dir.create_dir_all()?; |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note test
| OsString::from("--root-dir"), | ||
| OsString::from( | ||
| node_data_dir | ||
| .to_path_buf() |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note test
| enable_metrics_server: false, | ||
| env_variables: None, | ||
| home_network: false, | ||
| log_format: None, |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note test
| mock_service_control | ||
| .expect_get_process_pid() | ||
| .with(eq(current_node_bin.to_path_buf().clone())) | ||
| .times(1) |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
No description provided.