Bug/required field does not display as required in the WP Mailchimp settings page #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs:feedback
|
@MaxwellGarceau thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
github-actions
bot
added
needs:code-review
Done |
MaxwellGarceau
changed the title
MaxwellGarceau
changed the title
dkotter
approved these changes
Jan 3, 2025
MaxwellGarceau
requested review from
qasumitbagthariya
and removed request for
qasumitbagthariya
|
Removing request for a review from @qasumitbagthariya so that @dkotter can be the person to advance tickets to the next stage (read your note on #97 (comment) just a little too late haha). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In order to avoid duplicating information, please see #102 for a description of the original bug.
merge-field-required-label-does-not-appear-in-wp-admin.mov
Solution
Update strict equality comparison check to force the required field to have the same type. This fixes the bug and will cause merge fields to correctly display if they are required in the Mailchimp WP admin page.
Closes #102
How to test the Change
This video in the "Description of the Change" demonstrating the original bug can be used as a walkthrough. However, instead of the bug you should see the fix.
Changelog Entry
Credits
Props @MaxwellGarceau
Checklist:
I have updated the documentation accordingly.Small change, no documentation to updateI have added tests to cover my change.Small change, not worth the test