Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing subscriber can sign up even if "Update Existing Subscriber?" is turned off #114

Open
1 task done
MaxwellGarceau opened this issue Jan 9, 2025 · 0 comments · May be fixed by #115
Open
1 task done

Existing subscriber can sign up even if "Update Existing Subscriber?" is turned off #114

MaxwellGarceau opened this issue Jan 9, 2025 · 0 comments · May be fixed by #115
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@MaxwellGarceau
Copy link
Collaborator

Describe the bug

An existing subscriber can sign up with the same email and not receive the expected "This email address is already subscribed to the list."

Introduced with == loose equality to === strict equality change.

Steps to Reproduce

  1. Turn off "Update Existing Subscriber?"
  2. Sign up with an email address
  3. Use the same email address to sign up again
  4. The submission will succeed where it should have failed

Screenshots, screen recording, code snippet

subscriber-already-exists-check-ignored.mov
subscriber-exist-successful-signup

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MaxwellGarceau MaxwellGarceau added the type:bug Something isn't working. label Jan 9, 2025
@MaxwellGarceau MaxwellGarceau self-assigned this Jan 9, 2025
@jeffpaul jeffpaul added this to the 1.7.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants