fix: owners set UNDER_LIMIT status when Remaining=0 #212
Conversation
| @@ -224,11 +224,15 @@ func (gm *globalManager) broadcastPeers(ctx context.Context, updates map[string] | |||
| SetBehavior(&rl.Behavior, Behavior_GLOBAL, false) | |||
| rl.Hits = 0 | |||
|
|
|||
| status, err := gm.instance.getLocalRateLimit(ctx, rl) | |||
| misleadingStatus, err := gm.instance.getLocalRateLimit(ctx, rl) | |||
There was a problem hiding this comment.
did you confirm with the test that this returns with the correct result? I saw various places where the "fix" could be made at the time but it's hard to know if there is any knock on effects elsewhere without knowing the codebase more thoroughly.
Hopefully it is this simple :)
There was a problem hiding this comment.
I've only stared at the codebase for a couple of hours haha. As I mentioned here #208 (comment) the other place where I thought we could fix this is in algorithms.go.. but I am not comfortable changing that code because it doesn't have any unit tests 😬
| { | ||
| Name: "test_global", | ||
| UniqueKey: "account:12345", | ||
| Algorithm: guber.Algorithm_LEAKY_BUCKET, |
There was a problem hiding this comment.
@miparnisari - I think we will want to extend the test case to cover both algorithms perhaps?
|
Hi all! I think I have a fix for this in PR #216, please check it out! |
This is a copy of #207 but with a potential fix in place.
Closes #208