This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
fix: goroutine leaks #221
Merged
fix: goroutine leaks #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miparnisari
commented
Feb 18, 2024
miparnisari
commented
Feb 18, 2024
Baliedge
suggested changes
Feb 19, 2024
|
@miparnisari Not sure if you've noticed. There's still a failing test that seems relevant to your changes. |
thrawn01
reviewed
Feb 21, 2024
|
@miparnisari You'll need to fix a merge conflict, then I'll merge. |
Baliedge
approved these changes
Feb 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gubernator has some goroutine leaks stemming from not properly closing resources. These leaks are not many. However, any software that uses gubernator and that wants to assert that it has 0 leaks will get leaks coming from gubernator 😅