This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 99
Commits on Feb 26, 2024
-
Fix global behavior
ResetTime
bug.Every call to `GetRateLimits` would reset the `ResetTime` and not the `Remaining` counter. This would cause counters to eventually deplete and never fully reset.
Configuration menu - View commit details
-
Copy full SHA for f02cb5b - Browse repository at this point
Copy the full SHA f02cb5bView commit details
Commits on Feb 28, 2024
-
Refine request time propagation.
Request time is resolved at first call to `getLocalRateLimit()`, then is propagated across peer-to-peer for global behavior.
Configuration menu - View commit details
-
Copy full SHA for a665c3c - Browse repository at this point
Copy the full SHA a665c3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 427dd2b - Browse repository at this point
Copy the full SHA 427dd2bView commit details
Commits on Mar 6, 2024
-
Fix race condition in global behavior.
QueueUpdate() allowed for sending request/response when local ratelimits are updated. However, the order they get called to QueueUpdate() is not guaranteed to be chronological. This causes stale updates to propagate, causing lost hits. Instead, QueueUpdate() will only pass the request. The current ratelimit state will be retrieved immediately before propagation. Rigorous functional tests added around global behavior.
Configuration menu - View commit details
-
Copy full SHA for 57a5c97 - Browse repository at this point
Copy the full SHA 57a5c97View commit details
Commits on Mar 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 56a0b22 - Browse repository at this point
Copy the full SHA 56a0b22View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb3816a - Browse repository at this point
Copy the full SHA cb3816aView commit details
Commits on Mar 11, 2024
-
Refactor global behavior and functional tests for stability.
- Simplify passing of request time across layers. - Better handling of metrics in tests. - Better detection of global broadcasts, global updates, and idle. - Drop redundant metric `guberator_global_broadcast_counter`. - Fix metric `gubernator_global_queue_length` for global broadcast. - Add metric `gubernator_global_send_queue_length` for global send.
Configuration menu - View commit details
-
Copy full SHA for e2b8853 - Browse repository at this point
Copy the full SHA e2b8853View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c67a32 - Browse repository at this point
Copy the full SHA 7c67a32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24bee89 - Browse repository at this point
Copy the full SHA 24bee89View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea42442 - Browse repository at this point
Copy the full SHA ea42442View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd38ee6 - Browse repository at this point
Copy the full SHA bd38ee6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65ee4fa - Browse repository at this point
Copy the full SHA 65ee4faView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5c74d2 - Browse repository at this point
Copy the full SHA d5c74d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd7bbab - Browse repository at this point
Copy the full SHA cd7bbabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fb2a33 - Browse repository at this point
Copy the full SHA 0fb2a33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47eede5 - Browse repository at this point
Copy the full SHA 47eede5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2229596 - Browse repository at this point
Copy the full SHA 2229596View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0608d5 - Browse repository at this point
Copy the full SHA c0608d5View commit details -
Metric
gubernator_getratelimit_counter
adds calltype value "local n……on-owner" Better tracks the code path. Can exclude non-owner activity. Can get accurate total rate limit checks with query like `rate(gubernator_getratelimit_counter{calltype="local"}[1m])`
Configuration menu - View commit details
-
Copy full SHA for 517bf63 - Browse repository at this point
Copy the full SHA 517bf63View commit details -
Changed mind. Instead of
calltype="local non-owner"
, just don't inc……rement a counter.
Configuration menu - View commit details
-
Copy full SHA for 5f137ad - Browse repository at this point
Copy the full SHA 5f137adView commit details
Commits on Mar 12, 2024
-
Don't call
OnChange()
event from non-owner.Non-owners shouldn't be persisting rate limit state.
Configuration menu - View commit details
-
Copy full SHA for f51861d - Browse repository at this point
Copy the full SHA f51861dView commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d55016d - Browse repository at this point
Copy the full SHA d55016dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce3bc1 - Browse repository at this point
Copy the full SHA 5ce3bc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b2adf6 - Browse repository at this point
Copy the full SHA 0b2adf6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.