Add AddLink method to DummySpan #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtopc
reviewed
Apr 19, 2024
vtopc
approved these changes
Apr 22, 2024
|
Thanks @vtopc - once this PR is merged it will unblock our project |
No. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only in case you'd rather not merge #191 because of the minimum go version bump.
As it stands, projects with holster as indirect dependency cannot build if they also use otel v1.25.0. See also #189
For example, a project using gubernator and otel 1.25.0 cannot build at the moment, because of this.
OTel added a new function to the Span interface, so this PR is the minimal change that can unblock things. I would prefer #191 to be merged, but either will work.