PIPR-352: Add mxresolv.LookupWithPref #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewEdge
reviewed
May 17, 2024
mxresolv/mxresolv.go
Outdated
| // returns a prioritised list of MX hostnames, where hostnames with the same | ||
| // priority are shuffled. If the second returned value is true, then the host | ||
| // does not have explicit MX records, and its A record is returned instead. | ||
| // | ||
| // It uses an LRU cache with a timeout to reduce the number of network requests. | ||
| func Lookup(ctx context.Context, hostname string) (retMxHosts []string, retImplicit bool, reterr error) { | ||
| if cachedVal, ok := lookupResultCache.Get(hostname); ok { | ||
| func Lookup(ctx context.Context, domain string) ([]string, bool, error) { |
There was a problem hiding this comment.
I agree with the linter here. The names help with code completion for quick-glance reading
MatthewEdge
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
mxresolv.Lookupfunctionmxresolv.LookupWithPrefreturns a slice of*net.MXrecords that are ordered by preference and hostname when the preference is the same.