Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade toolchain version #197

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Downgrade toolchain version #197

merged 5 commits into from
Jul 29, 2024

Conversation

vtopc
Copy link
Contributor

@vtopc vtopc commented Jul 26, 2024

On master branch the toolchain directive adds a weird side effect:

# go version
go version go1.21.12 darwin/arm64

# cd holster
# go version
go: downloading go1.22.2 (darwin/arm64)
go version go1.22.2 darwin/arm64

and our 1.21 CI tests test it on 1.22:

Run actions/setup-go@v5
Setup go version spec 1.21.x
Found in cache @ /opt/hostedtoolcache/go/1.21.10/x64
Added go to the path
Successfully set up Go version 1.21.x
go: downloading go1.22.2 (linux/amd64)
...
Cache is not found
go version go1.22.2 linux/amd64

https://github.com/mailgun/holster/actions/runs/9158167548/job/25175965954

but all other services are using 1.21


It was added in https://github.com/mailgun/holster/pull/191/files?w=1


What is Go Toolchains - https://go.dev/doc/toolchain


Tested with https://github.com/mailgun/maverick-score/pull/84

@vtopc vtopc changed the title drop unsupported toolchain version Downgrade toolchain version Jul 26, 2024
@vtopc vtopc marked this pull request as ready for review July 26, 2024 13:32
@vtopc vtopc requested review from a team and Baliedge July 26, 2024 13:40
docker-compose.yaml Outdated Show resolved Hide resolved
@vtopc vtopc merged commit c6a54bc into master Jul 29, 2024
3 checks passed
@vtopc vtopc deleted the vtopc/drop_toolchain branch July 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants