Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rabbitmq broker #56

Merged
merged 10 commits into from
Jul 28, 2023
Merged

Add support for rabbitmq broker #56

merged 10 commits into from
Jul 28, 2023

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Jul 20, 2023

Signed-off-by: SammyOina sammyoina@gmail.com

What does this do?

Allows for nats and rabbit mq as brokers on agent as in mainflux.

Which issue(s) does this PR fix/relate to?

Resolves #55

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

yes absmach/magistrala-docs#152

Notes

@SammyOina
Copy link
Contributor Author

To be merged after #53

drasko
drasko previously approved these changes Jul 24, 2023
Copy link
Member

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina SammyOina marked this pull request as ready for review July 24, 2023 14:03
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
README.md Outdated Show resolved Hide resolved
config.toml Outdated Show resolved Hide resolved
examples/publish/main.go Show resolved Hide resolved
pkg/agent/api/endpoints_test.go Outdated Show resolved Hide resolved
pkg/agent/service.go Outdated Show resolved Hide resolved
Signed-off-by: SammyOina <sammyoina@gmail.com>
Copy link
Member

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit a6e6d4f into mainflux:master Jul 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support For Multi-broker Messaging From Mainflux
3 participants