NOISSUE - Test and Enhance Py SDK

[Musilah]

What does this do?

Test and Enhance Py SDK

Which issue(s) does this PR fix/relate to?

Resolves https://github.com/ultravioletrs/issues/issues/284

List any changes that modify/break current functionality

None so far

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

[rodneyosodo]

Have a look at https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings also https://www.dataquest.io/blog/documenting-in-python-with-docstrings/. So that we can enhance documentation of the sdk

[rodneyosodo]

For docstring I meant something similar to this

class Users:
    """Users API client.
    
    Users API is used for creating and managing users.
    It is used for creating new users, logging in, refreshing tokens,
    getting user information, updating user information, disabling and enabling users.
    
    Attributes:
        URL: str - URL of the Users API
        USERS_ENDPOINT: str - Users API endpoint
    """
    USERS_ENDPOINT = "users"

    def __init__(self, url: str):
        """Initializes Users API client.
        
        params:
            url: str - URL of the Users API
        
        returns:
            Users: Users - Users API client
            
        raises:
            None
        """
        self.URL = url

    def create(self, user: dict, token: str = ""):
        """Creates a new user.
        
        Creates a new user with provided user information.
        If token is provided, it will be used to create a new user.

        params:
            user: dict - user information for example:
            
            {
                "name": "example",
                "credentials": {
                    "identity": "example@main.com",
                    "secret": "12345678"
                }
            }
            token: str - token used for creating a new user
            
        returns:
            mf_resp: response.Response - response object

        Usage::
            
            >>> from mainflux import sdk
            >>> mfsdk = sdk.SDK(users_url="http://localhost:9002")
            >>> user = {
            ...     "name": "example",
            ...     "credentials": {
            ...         "identity": "example@mail.com",
            ...         "secret": "12345678"
            ...     }
            ... }
            >>> mf_resp = mfsdk.users.create(user)
            >>> mf_resp            
        """
        mf_resp = response.Response()
        http_resp = requests.post(
            self.URL + "/users",
            json=user,
            headers=utils.construct_header(token, utils.CTJSON),
        )
        if http_resp.status_code != 201:
            mf_resp.error.status = 1
            mf_resp.error.message = errors.handle_error(
                errors.users["create"], http_resp.status_code
            )
        else:
            mf_resp.value = http_resp.json()
        return mf_resp

[fbugarski]

You can assign a value's to the access_token and rest variables like this:

`access_token = "<access_token>"
refresh_token = "<refresh_token>"

email=""
password =""`

and avoid it in every func

"""To start working with the Mainflux system, you need to create a user account""" mf_resp = mfsdk.users.create( user={"credentials": {"identity": email, "secret": password}}, token="", ) if mf_resp.error.status == 0: print(mf_resp.value) else: print(mf_resp.error.message)

@dborovcanin and @drasko what do you think ?

[drasko]

I do not understand the question. Maybe @dborovcanin can answer.

[fbugarski]

LGTM

[drasko]

Fix the Markdown

[drasko]

LGTM